[
https://issues.apache.org/jira/browse/BEAM-5840?focusedWorklogId=157872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157872
]
ASF GitHub Bot logged work on BEAM-5840:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/18 23:06
Start Date: 23/Oct/18 23:06
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6803: [BEAM-5840] Add
initial jenkins job to verify community metrics infra.
URL: https://github.com/apache/beam/pull/6803
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/job_PreCommit_CommunityMetrics.groovy
b/.test-infra/jenkins/job_PreCommit_CommunityMetrics.groovy
new file mode 100644
index 00000000000..005204ed607
--- /dev/null
+++ b/.test-infra/jenkins/job_PreCommit_CommunityMetrics.groovy
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+ scope: this,
+ nameBase: 'Community Metrics',
+ gradleTask: ':communitymetricsPreCommit',
+ triggerPathPatterns: ['^.test-infra/metrics/.*$']
+)
+builder.build()
+
diff --git a/.test-infra/metrics/build.gradle b/.test-infra/metrics/build.gradle
new file mode 100644
index 00000000000..2e68f4fbf04
--- /dev/null
+++ b/.test-infra/metrics/build.gradle
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: "base"
+
+task testMetricsStack {
+ doLast {
+ // TODO(BEAM-5837): Add some actual validation of the metrics stack
+ println "Hello world!"
+ }
+}
+
+task preCommit {
+ dependsOn testMetricsStack
+}
+
diff --git a/build.gradle b/build.gradle
index 2817a8a54a2..2606ef62e46 100644
--- a/build.gradle
+++ b/build.gradle
@@ -247,6 +247,10 @@ task websitePreCommit() {
dependsOn ":beam-website:preCommit"
}
+task communityMetricsPreCommit() {
+ dependsOn ":rat"
+ dependsOn ":beam-test-infra-metrics:preCommit"
+}
task runBeamDependencyCheck() {
dependsOn ":dependencyUpdates"
diff --git a/settings.gradle b/settings.gradle
index 1e88ccdf92c..115cb9ce5b1 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -190,3 +190,5 @@ include
"beam-runners-google-cloud-dataflow-java-fn-api-worker"
project(":beam-runners-google-cloud-dataflow-java-fn-api-worker").dir =
file("runners/google-cloud-dataflow-java/worker")
include "beam-runners-google-cloud-dataflow-java-windmill"
project(":beam-runners-google-cloud-dataflow-java-windmill").dir =
file("runners/google-cloud-dataflow-java/worker/windmill")
+include "beam-test-infra-metrics"
+project(":beam-test-infra-metrics").dir = file(".test-infra/metrics")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157872)
Time Spent: 20m (was: 10m)
> Add unit tests for import scripts
> ---------------------------------
>
> Key: BEAM-5840
> URL: https://issues.apache.org/jira/browse/BEAM-5840
> Project: Beam
> Issue Type: Sub-task
> Components: project-management
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For custom import scripts, we should refactor the logic to be testable and
> add some basic unit tests.
> At the very least, there should be some "smoke test" that the local
> deployment works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
