[
https://issues.apache.org/jira/browse/BEAM-5840?focusedWorklogId=158285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158285
]
ASF GitHub Bot logged work on BEAM-5840:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 19:51
Start Date: 24/Oct/18 19:51
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6806: [BEAM-5840] Validate
'docker-compose up'
URL: https://github.com/apache/beam/pull/6806
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/metrics/build.gradle b/.test-infra/metrics/build.gradle
index 2e68f4fbf04..983a44c192f 100644
--- a/.test-infra/metrics/build.gradle
+++ b/.test-infra/metrics/build.gradle
@@ -18,12 +18,16 @@
apply plugin: "base"
+// https://github.com/avast/gradle-docker-compose-plugin
+apply plugin: "com.avast.gradle.docker-compose"
+
task testMetricsStack {
doLast {
// TODO(BEAM-5837): Add some actual validation of the metrics stack
println "Hello world!"
}
}
+dockerCompose.isRequiredBy(testMetricsStack)
task preCommit {
dependsOn testMetricsStack
diff --git a/build.gradle b/build.gradle
index 09d5f439838..da88f4d0f47 100644
--- a/build.gradle
+++ b/build.gradle
@@ -64,6 +64,7 @@ buildscript {
classpath "net.ltgt.gradle:gradle-errorprone-plugin:0.0.13"
// Enable errorprone Java static analysis
classpath "com.github.ben-manes:gradle-versions-plugin:0.17.0"
// Enable dependency checks
classpath "org.ajoberstar.grgit:grgit-gradle:3.0.0-beta.1"
// Enable website git publish to asf-site branch
+ classpath "com.avast.gradle:gradle-docker-compose-plugin:0.8.8"
// Enable docker compose tasks
// Plugins which require online access should not be enabled when running
in offline mode.
if (!gradle.startParameter.isOffline()) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158285)
Time Spent: 1h 20m (was: 1h 10m)
> Add unit tests for import scripts
> ---------------------------------
>
> Key: BEAM-5840
> URL: https://issues.apache.org/jira/browse/BEAM-5840
> Project: Beam
> Issue Type: Sub-task
> Components: project-management
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> For custom import scripts, we should refactor the logic to be testable and
> add some basic unit tests.
> At the very least, there should be some "smoke test" that the local
> deployment works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
