[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160182
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 20:16
Start Date: 29/Oct/18 20:16
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #6868: [BEAM-5887]
Rollforward "Fix classifier for unshaded tests"
URL: https://github.com/apache/beam/pull/6868
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 18543ced40d..edeafb73703 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -608,7 +608,7 @@ class BeamModulePlugin implements Plugin<Project> {
// Ensure that tests are packaged and part of the artifact set.
project.task('packageTests', type: Jar) {
- classifier = 'tests'
+ classifier = 'tests-unshaded'
from project.sourceSets.test.output
}
project.artifacts.archives project.packageTests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160182)
Time Spent: 4h (was: 3h 50m)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
