[
https://issues.apache.org/jira/browse/BEAM-3608?focusedWorklogId=160244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160244
]
ASF GitHub Bot logged work on BEAM-3608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:13
Start Date: 29/Oct/18 22:13
Worklog Time Spent: 10m
Work Description: dmvk commented on a change in pull request #6809:
[BEAM-3608] Vendor guava 20.0
URL: https://github.com/apache/beam/pull/6809#discussion_r229117812
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/Repositories.groovy
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.gradle
+
+import org.gradle.api.Project
+
+class Repositories {
Review comment:
nit: Did you think about using `@CompileStatic` in groovy build plugins? It
is little bit more verbose to write the plugin, but on the other hand it may be
more "user friendly" for people that want to contribute to build scripts and
don't have a strong groovy / gradle background (it allows then to use auto
complete, compile time checks, ...).
http://docs.groovy-lang.org/latest/html/gapi/groovy/transform/CompileStatic.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160244)
Time Spent: 4h (was: 3h 50m)
> Vendor Guava
> ------------
>
> Key: BEAM-3608
> URL: https://issues.apache.org/jira/browse/BEAM-3608
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Instead of shading as part of our build, we can shade before build so that it
> is apparent when reading code, and in IDEs, that a particular class resides
> in a hidden namespace.
> {{import com.google.common.reflect.TypeToken}}
> becomes something like
> {{import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken}}
> So we can very trivially ban `org.apache.beam.private` from public APIs
> unless they are annotated {{@Internal}}, and it makes sharing between our own
> modules never get broken by shading again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
