[
https://issues.apache.org/jira/browse/BEAM-3608?focusedWorklogId=160255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160255
]
ASF GitHub Bot logged work on BEAM-3608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:27
Start Date: 29/Oct/18 22:27
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #6809: [BEAM-3608] Vendor
guava 20.0
URL: https://github.com/apache/beam/pull/6809#issuecomment-434104239
@CompileStatic is neat, apply it to all our groovy files?
Would it work on Gradle files?
On Mon, Oct 29, 2018 at 3:16 PM Kenn Knowles <[email protected]>
wrote:
> *@kennknowles* commented on this pull request.
> ------------------------------
>
> In buildSrc/src/main/groovy/org/apache/beam/gradle/Repositories.groovy
> <https://github.com/apache/beam/pull/6809#discussion_r229118455>:
>
> > + * with the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an AS IS BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +package org.apache.beam.gradle
> +
> +import org.gradle.api.Project
> +
> +class Repositories {
>
> I didn't know about it. I will definitely use it if it doesn't break
> Gradle's funky magic. Even better would be moving everything to Kotlin :-)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/6809#discussion_r229118455>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AJnK7N3aQBt_8Or6bPhe7ct9xLxT4-8Iks5up34lgaJpZM4X3CXM>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160255)
Time Spent: 4h 20m (was: 4h 10m)
> Vendor Guava
> ------------
>
> Key: BEAM-3608
> URL: https://issues.apache.org/jira/browse/BEAM-3608
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Instead of shading as part of our build, we can shade before build so that it
> is apparent when reading code, and in IDEs, that a particular class resides
> in a hidden namespace.
> {{import com.google.common.reflect.TypeToken}}
> becomes something like
> {{import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken}}
> So we can very trivially ban `org.apache.beam.private` from public APIs
> unless they are annotated {{@Internal}}, and it makes sharing between our own
> modules never get broken by shading again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
