[
https://issues.apache.org/jira/browse/BEAM-3608?focusedWorklogId=160276&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160276
]
ASF GitHub Bot logged work on BEAM-3608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:34
Start Date: 29/Oct/18 22:34
Worklog Time Spent: 10m
Work Description: dmvk edited a comment on issue #6809: [BEAM-3608]
Vendor guava 20.0
URL: https://github.com/apache/beam/pull/6809#issuecomment-434105858
I think that the difference between gradle and groovy files would be, that
they are interpreted instead of compiled, therefore these checks might not be
applicable. This is just my best guess, I may be wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160276)
Time Spent: 4h 40m (was: 4.5h)
> Vendor Guava
> ------------
>
> Key: BEAM-3608
> URL: https://issues.apache.org/jira/browse/BEAM-3608
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Instead of shading as part of our build, we can shade before build so that it
> is apparent when reading code, and in IDEs, that a particular class resides
> in a hidden namespace.
> {{import com.google.common.reflect.TypeToken}}
> becomes something like
> {{import org.apache.beam.private.guava21.com.google.common.reflect.TypeToken}}
> So we can very trivially ban `org.apache.beam.private` from public APIs
> unless they are annotated {{@Internal}}, and it makes sharing between our own
> modules never get broken by shading again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
