[
https://issues.apache.org/jira/browse/BEAM-5878?focusedWorklogId=160783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160783
]
ASF GitHub Bot logged work on BEAM-5878:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 19:01
Start Date: 30/Oct/18 19:01
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6781:
[BEAM-5878] [BEAM-5490] Add partial support for functions with keyword-only
arguments.
URL: https://github.com/apache/beam/pull/6781#discussion_r229444391
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -259,15 +263,30 @@ def _unpack_positional_arg_hints(arg, hint):
def getcallargs_forhints(func, *typeargs, **typekwargs):
"""Like inspect.getcallargs, but understands that Tuple[] and an Any unpack.
"""
- argspec = inspect.getargspec(func)
+ argspec = getfullargspec(func)
# Turn Tuple[x, y] into (x, y) so getcallargs can do the proper unpacking.
packed_typeargs = [_unpack_positional_arg_hints(arg, hint)
for (arg, hint) in zip(argspec.args, typeargs)]
packed_typeargs += list(typeargs[len(packed_typeargs):])
+
+ # Monkeypatch inspect.getfullargspec to allow passing non-function objects.
+ # getfullargspec (getargspec on Python 2) are used by inspect.getcallargs.
+ if _use_legacy_getargspec: # Python 2
+ inspect.getargspec = getfullargspec
+ else:
+ inspect.getfullargspec = getfullargspec
+
try:
callargs = inspect.getcallargs(func, *packed_typeargs, **typekwargs)
except TypeError as e:
raise TypeCheckError(e)
+ finally:
+ # Revert monkey-patch.
Review comment:
I think we should fully stop doing the monkey patching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160783)
Time Spent: 1h (was: 50m)
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to
> define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one
> place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118]
> in our codebase that we should fix: in Python in 3.0 inspect.getargspec()
> will fail on functions with keyword-only arguments, but a new method
> [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec]
> supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only
> arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
