[
https://issues.apache.org/jira/browse/BEAM-5878?focusedWorklogId=160884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160884
]
ASF GitHub Bot logged work on BEAM-5878:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 22:04
Start Date: 30/Oct/18 22:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6781:
[BEAM-5878] [BEAM-5490] Add partial support for functions with keyword-only
arguments.
URL: https://github.com/apache/beam/pull/6781#discussion_r229502868
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -442,12 +442,21 @@ def is_process_bounded(self):
def _fn_takes_side_inputs(fn):
try:
- argspec = inspect.getargspec(fn)
+ argspec = getfullargspec(fn)
except TypeError:
# We can't tell; maybe it does.
return True
is_bound = isinstance(fn, types.MethodType) and fn.__self__ is not None
- return len(argspec.args) > 1 + is_bound or argspec.varargs or
argspec.keywords
+
+ try:
+ varkw = argspec.varkw
+ kwonlyargs = argspec.kwonlyargs
+ except AttributeError: # Python 2
+ varkw = argspec.keywords
+ kwonlyargs = []
+
+ return (len(argspec.args) + len(kwonlyargs) > 1 + is_bound or
Review comment:
We preserve the original intent: to check that total number of arguments is
more than 1, or 2 if the method is bound.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160884)
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to
> define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one
> place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118]
> in our codebase that we should fix: in Python in 3.0 inspect.getargspec()
> will fail on functions with keyword-only arguments, but a new method
> [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec]
> supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only
> arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
