[
https://issues.apache.org/jira/browse/BEAM-5878?focusedWorklogId=160885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160885
]
ASF GitHub Bot logged work on BEAM-5878:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 22:04
Start Date: 30/Oct/18 22:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6781:
[BEAM-5878] [BEAM-5490] Add partial support for functions with keyword-only
arguments.
URL: https://github.com/apache/beam/pull/6781#discussion_r229503245
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -112,38 +112,42 @@ def foo((a, b)):
_MethodDescriptorType = type(str.upper)
# pylint: enable=invalid-name
+try:
+ _original_getfullargspec = inspect.getfullargspec
+ _use_legacy_getargspec = False
+except AttributeError: # Python 2
+ _original_getfullargspec = inspect.getargspec
+ _use_legacy_getargspec = True
-# Monkeypatch inspect.getargspec to allow passing non-function objects.
-# This is needed to use higher-level functions such as getcallargs.
-_original_getargspec = inspect.getargspec
-
-def getargspec(func):
+def getfullargspec(func):
try:
- return _original_getargspec(func)
+ return _original_getfullargspec(func)
except TypeError:
if isinstance(func, type):
- argspec = getargspec(func.__init__)
+ argspec = getfullargspec(func.__init__)
del argspec.args[0]
return argspec
elif callable(func):
try:
- return _original_getargspec(func.__call__)
+ return _original_getfullargspec(func.__call__)
except TypeError:
# Return an ArgSpec with at least one positional argument,
# and any number of other (positional or keyword) arguments
- # whose name won't match any real agument.
+ # whose name won't match any real argument.
# Arguments with the %unknown% prefix will be ignored in the type
# checking code.
- return inspect.ArgSpec(
- ['_'], '__unknown__varargs', '__unknown__keywords', ())
+ try:
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160885)
Time Spent: 1h 10m (was: 1h)
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to
> define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one
> place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118]
> in our codebase that we should fix: in Python in 3.0 inspect.getargspec()
> will fail on functions with keyword-only arguments, but a new method
> [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec]
> supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only
> arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
