[
https://issues.apache.org/jira/browse/BEAM-5961?focusedWorklogId=162188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162188
]
ASF GitHub Bot logged work on BEAM-5961:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/18 04:22
Start Date: 03/Nov/18 04:22
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #6933:
[BEAM-5961] Nexmark rollforward new query with test of Nexmark main
URL: https://github.com/apache/beam/pull/6933
This adds a test to main that should catch the issue with the Nexmark SMOKE
suite in precommit. Pushing out now to demonstrate precommit failure, then
fixing.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162188)
Time Spent: 10m
Remaining Estimate: 0h
> No precommit coverage for Nexmark postcommit main entry point
> -------------------------------------------------------------
>
> Key: BEAM-5961
> URL: https://issues.apache.org/jira/browse/BEAM-5961
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There's a decent amount of logic in Nexmark's {{Main}} class and
> {{NexmarkLauncher}}, neither of which have any tests. It is extremely easy to
> make a change that breaks the Nexmark postcommits with no signal before a PR
> is merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
