[
https://issues.apache.org/jira/browse/BEAM-5961?focusedWorklogId=162577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162577
]
ASF GitHub Bot logged work on BEAM-5961:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/18 16:58
Start Date: 05/Nov/18 16:58
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #6933:
[BEAM-5961] Nexmark rollforward new query with test of Nexmark main
URL: https://github.com/apache/beam/pull/6933#discussion_r230829701
##########
File path:
sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/MainTest.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.nexmark;
+
+import org.apache.beam.sdk.options.PipelineOptionsFactory;
+import org.junit.Test;
+
+/**
+ * Test of {@link Main}; using {@link NexmarkOptions} since we don't want to
test option parsing
+ * here.
+ */
+public class MainTest {
+ @Test
+ public void testSmokeSuiteOnDirectRunner() throws Exception {
+ NexmarkOptions options =
PipelineOptionsFactory.create().as(NexmarkOptions.class);
Review comment:
I think it would make sense to limit number of events here for the test to
reduce the run time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162577)
Time Spent: 0.5h (was: 20m)
> No precommit coverage for Nexmark postcommit main entry point
> -------------------------------------------------------------
>
> Key: BEAM-5961
> URL: https://issues.apache.org/jira/browse/BEAM-5961
> Project: Beam
> Issue Type: Bug
> Components: examples-nexmark
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There's a decent amount of logic in Nexmark's {{Main}} class and
> {{NexmarkLauncher}}, neither of which have any tests. It is extremely easy to
> make a change that breaks the Nexmark postcommits with no signal before a PR
> is merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
