[ 
https://issues.apache.org/jira/browse/BEAM-5961?focusedWorklogId=162962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162962
 ]

ASF GitHub Bot logged work on BEAM-5961:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Nov/18 09:09
            Start Date: 06/Nov/18 09:09
    Worklog Time Spent: 10m 
      Work Description: echauchot edited a comment on issue #6933: [BEAM-5961] 
Nexmark rollforward new query with test of Nexmark main
URL: https://github.com/apache/beam/pull/6933#issuecomment-436180247
 
 
   I did not have the chance de comment before merging due to timezones :)
   Anyway, it is only minor javadoc comments. I'll submit a quick PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 162962)
    Time Spent: 1h 20m  (was: 1h 10m)

> No precommit coverage for Nexmark postcommit main entry point
> -------------------------------------------------------------
>
>                 Key: BEAM-5961
>                 URL: https://issues.apache.org/jira/browse/BEAM-5961
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-nexmark
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> There's a decent amount of logic in Nexmark's {{Main}} class and 
> {{NexmarkLauncher}}, neither of which have any tests. It is extremely easy to 
> make a change that breaks the Nexmark postcommits with no signal before a PR 
> is merged.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to