[
https://issues.apache.org/jira/browse/BEAM-5939?focusedWorklogId=163532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163532
]
ASF GitHub Bot logged work on BEAM-5939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/18 17:46
Start Date: 07/Nov/18 17:46
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6976:
[BEAM-5939] Dedupe runner constants
URL: https://github.com/apache/beam/pull/6976#discussion_r231608251
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -51,6 +51,7 @@
from apache_beam.runners.dataflow.internal import names
from apache_beam.runners.dataflow.internal.clients import dataflow
from apache_beam.runners.dataflow.internal.names import PropertyNames
+from apache_beam.runners.internal.names import BEAM_PACKAGE_NAME, BEAM_SDK_NAME
Review comment:
I believe it would be more clear, if you import names, and then use
names.BEAM_PACKAGE_NAME etc. in the code. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163532)
Time Spent: 20m (was: 10m)
> Deduplicate constants
> ---------------------
>
> Key: BEAM-5939
> URL: https://issues.apache.org/jira/browse/BEAM-5939
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Minor
> Labels: starer
> Time Spent: 20m
> Remaining Estimate: 0h
>
> apache_beam/runners/dataflow/internal/names.py
> apache_beam/runners/portability/stager.py
> has same constants defined in both files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
