[
https://issues.apache.org/jira/browse/BEAM-5939?focusedWorklogId=163540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163540
]
ASF GitHub Bot logged work on BEAM-5939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/18 18:01
Start Date: 07/Nov/18 18:01
Worklog Time Spent: 10m
Work Description: brianmartin commented on a change in pull request
#6976: [BEAM-5939] Dedupe runner constants
URL: https://github.com/apache/beam/pull/6976#discussion_r231615270
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/names.py
##########
@@ -22,11 +22,9 @@
from __future__ import absolute_import
-# TODO (altay): Move shared names to a common location.
# Standard file names used for staging files.
from builtins import object
-PICKLED_MAIN_SESSION_FILE = 'pickled_main_session'
DATAFLOW_SDK_TARBALL_FILE = 'dataflow_python_sdk.tar'
STAGED_PIPELINE_FILENAME = "pipeline.pb"
Review comment:
I've moved `STAGED_PIPELINE_FILENAME ` to the common location. Though, it is
only used in the Dataflow runner. Also, the
`STAGED_PIPELINE_URL_METADATA_FIELD` constant was not used anywhere; I've
removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163540)
Time Spent: 40m (was: 0.5h)
> Deduplicate constants
> ---------------------
>
> Key: BEAM-5939
> URL: https://issues.apache.org/jira/browse/BEAM-5939
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Minor
> Labels: starer
> Time Spent: 40m
> Remaining Estimate: 0h
>
> apache_beam/runners/dataflow/internal/names.py
> apache_beam/runners/portability/stager.py
> has same constants defined in both files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
