[
https://issues.apache.org/jira/browse/BEAM-5939?focusedWorklogId=164186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164186
]
ASF GitHub Bot logged work on BEAM-5939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/18 01:30
Start Date: 09/Nov/18 01:30
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #6976: [BEAM-5939] Dedupe
runner constants
URL: https://github.com/apache/beam/pull/6976#issuecomment-437218002
Dataflow jobs passed, but there is a lint error. I am not sure why it did
not show up on precommits.
14:54:25 Running isort for module apache_beam gen_protos.py setup.py
test_config.py:
14:54:31 ERROR:
/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify_PR/src/sdks/python/apache_beam/runners/portability/stager.py
Imports are incorrectly sorted.
14:54:31 ---
/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify_PR/src/sdks/python/apache_beam/runners/portability/stager.py:before
2018-11-08 21:49:32.444622
14:54:31 +++
/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify_PR/src/sdks/python/apache_beam/runners/portability/stager.py:after
2018-11-08 22:54:29.293067
14:54:31 @@ -60,9 +60,9 @@
14:54:31 from apache_beam.io.filesystems import FileSystems
14:54:31 from apache_beam.options.pipeline_options import SetupOptions
14:54:31 from apache_beam.options.pipeline_options import WorkerOptions
14:54:31 -from apache_beam.runners.internal import names
14:54:31 # TODO(angoenka): Remove reference to dataflow internal names
14:54:31 from apache_beam.runners.dataflow.internal.names import
DATAFLOW_SDK_TARBALL_FILE
14:54:31 +from apache_beam.runners.internal import names
14:54:31 from apache_beam.utils import processes
14:54:31
14:54:31 # All constants are for internal use only; no
backwards-compatibility
14:54:31 Command exited with non-zero status 1
14:54:31 418.43user 9.73system 1:03.13elapsed 678%CPU (0avgtext+0avgdata
326144maxresident)k
14:54:31 0inputs+208outputs (0major+862242minor)pagefaults 0swaps
14:54:31 ERROR: InvocationError for command '/usr/bin/time
/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify_PR/src/sdks/python/scripts/run_pylint.sh'
(exited with code 1)
cc: @markflyhigh Any idea why precommits did not catch this lint issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 164186)
Time Spent: 1h 40m (was: 1.5h)
> Deduplicate constants
> ---------------------
>
> Key: BEAM-5939
> URL: https://issues.apache.org/jira/browse/BEAM-5939
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Minor
> Labels: starer
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> apache_beam/runners/dataflow/internal/names.py
> apache_beam/runners/portability/stager.py
> has same constants defined in both files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
