[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=165440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165440
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 14:01
Start Date: 13/Nov/18 14:01
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #6786: [BEAM-5850] Add
BeamFnDataReceiver and make process, finish and start run on the same thread to
support metrics.
URL: https://github.com/apache/beam/pull/6786#issuecomment-438275835
Generally the direction of this PR has be a bit concerned. While it is
convenient for users to be able to access and update metrics without having to
reference an explicit context, I would definitely prefer that all internal
access is explicit (e.g. no worrying about incrementing the wrong bundle's
counter because you happened to be on the wrong thread). Forcing these
executions to happen on the same thread just propagates this implicit
assumption rather than cleaning it up. I think it'd be much cleaner to enter
(and exit) the appropriate context on the desired thread (which presumably we'd
be doing for state sampling anyway). In addition, adding extra buffers and
queues is likely to hurt performance and makes understanding and debugging the
system much harder and raises issues like how one should appropriately size and
bound these queues. Is this the only (or at least best) way to support metrics?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165440)
Time Spent: 7h 40m (was: 7.5h)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
