[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=165845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165845
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 09:52
Start Date: 14/Nov/18 09:52
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #6786: [BEAM-5850] Add
BeamFnDataReceiver and make process, finish and start run on the same thread to
support metrics.
URL: https://github.com/apache/beam/pull/6786#issuecomment-438603335
On Tue, Nov 13, 2018 at 6:35 PM Lukasz Cwik <[email protected]>
wrote:
> @robertwb <https://github.com/robertwb> This to address a gap in the
> current Java SDK. The thread that executes StartBundle/FinishBundle calls
> is different from the thread that the calls ProcessElement breaking the
> thread safety expectations of DoFn authors.
>
Is this part of the contract? My understanding was that different threads
could be used, just not concurrently.
> This does make it easier to use implement the metrics API as it exists
> today but that is a side effect.
>
That's not how I read the title, but if this is where we want to go anyway
that's more OK (though the operational downsides still stand).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165845)
Time Spent: 8h 10m (was: 8h)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
