[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=165958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165958
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 16:39
Start Date: 14/Nov/18 16:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #6786: [BEAM-5850] Add
BeamFnDataReceiver and make process, finish and start run on the same thread to
support metrics.
URL: https://github.com/apache/beam/pull/6786#issuecomment-438729478
Your right Robert, I misremembered and looking at the contract we only
require users code to be thread compatible. We would just need to guarantee a
memory barrier between start / process element / finish assuming that all the
rest of the code that is part of the SDK has been written in a thread
compatible way as well.
We will still want to decouple the gRPC reader thread from the gRPC writer
thread because gRPC only invokes channel readiness callbacks on the reader
thread leading into issues where if the thread that is reading from gRPC writes
to gRPC needs to poll for channel readiness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165958)
Time Spent: 8h 20m (was: 8h 10m)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
