[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=165561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165561
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 18:17
Start Date: 13/Nov/18 18:17
Worklog Time Spent: 10m
Work Description: tweise commented on issue #7012: Revert "Revert "Revert
"[BEAM-5299] Define max timestamp for global w…
URL: https://github.com/apache/beam/pull/7012#issuecomment-438380016
> > @HuangLED I have a general question on why such "Revert" PRs surface out
of nowhere? I don't seem to find any email on the dev@ list about this. Which
"internal" tests are breaking? Why do we need to revert changes in Beam that
have been discussed at length? @lukecwik @chamikaramj @mxm
>
> Sorry for the confusion. internal testing refers to GCP dataflow service
internal testing.
There shouldn't be any confusion. Contributing policies and how we work as
community are documented here: https://beam.apache.org/contribute/
You won't find a mention of special provision for internal Dataflow testing
and more or less under the radar slamming reverts into the Beam repository.
This has happened repeatedly in the past and it is time we do better. In the
future, please discuss on the email list prior to opening a PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165561)
Time Spent: 14.5h (was: 14h 20m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Fix For: 2.9.0
>
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
