[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=165673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165673
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 22:29
Start Date: 13/Nov/18 22:29
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7012: Revert "Revert "Revert
"[BEAM-5299] Define max timestamp for global w…
URL: https://github.com/apache/beam/pull/7012#issuecomment-438462979
There is nothing wrong reverting this if it happens to break a critical
Runner. What was initially missing here, is an explanation, why this is
necessary and, more importantly, how it could be mitigated in the future. We
track such information in JIRA issues or directly in GitHub, to document and
share knowledge.
When I merged the initial PR, I wasn't aware of the Dataflow image and how
regularly it builds. Now, I will be more careful and, perhaps, we can work on a
solution in which we can test more easily if a change would break Dataflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165673)
Time Spent: 15h 20m (was: 15h 10m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Fix For: 2.9.0
>
> Time Spent: 15h 20m
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
