[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=165251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165251
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 01:05
Start Date: 13/Nov/18 01:05
Worklog Time Spent: 10m
Work Description: HuangLED commented on issue #7012: Revert "Revert
"Revert "[BEAM-5299] Define max timestamp for global w…
URL: https://github.com/apache/beam/pull/7012#issuecomment-438089110
> @HuangLED I have a general question on why such "Revert" PRs surface out
of nowhere? I don't seem to find any email on the dev@ list about this. Which
"internal" tests are breaking? Why do we need to revert changes in Beam that
have been discussed at length? @lukecwik @chamikaramj @mxm
Sorry for the confusing.
Initially thought a rollback was the best option. While creating this PR
though, I was also chatting with several folks regarding which way would be the
best fix. We ended up doing an internal java container release, followed by
https://github.com/apache/beam/pull/7014. Now the breaking test issue is gone.
We thus then closed this PR, before putting more information into it.
Please kindly let me know what else can done to clean up better after wards in
such a case.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165251)
Time Spent: 14h 10m (was: 14h)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Fix For: 2.9.0
>
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
