[
https://issues.apache.org/jira/browse/BEAM-5320?focusedWorklogId=165668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165668
]
ASF GitHub Bot logged work on BEAM-5320:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 22:25
Start Date: 13/Nov/18 22:25
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#7029: [BEAM-5320] Finish Python 3 porting for testing module
URL: https://github.com/apache/beam/pull/7029#discussion_r233246892
##########
File path: sdks/python/apache_beam/testing/synthetic_pipeline.py
##########
@@ -71,7 +71,7 @@ def div_round_up(a, b):
def rotate_key(element):
"""Returns a new key-value pair of the same size but with a different key."""
(key, value) = element
- return key[-1] + key[:-1], value
+ return key[-1:] + key[:-1], value
Review comment:
Bytearray indexing changed from Python 2 to Python 3. See
[docs](https://docs.python.org/3.1/library/stdtypes.html#sequence-types-str-bytes-bytearray-list-tuple-range)
> for a bytes or bytearray object b, b[0] will be an integer, while b[0:1]
will be a bytes or bytearray object of length 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165668)
Time Spent: 1h (was: 50m)
> Finish Python 3 porting for testing module
> ------------------------------------------
>
> Key: BEAM-5320
> URL: https://issues.apache.org/jira/browse/BEAM-5320
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Stijn Decubber
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
