[
https://issues.apache.org/jira/browse/BEAM-5320?focusedWorklogId=166137&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166137
]
ASF GitHub Bot logged work on BEAM-5320:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 21:55
Start Date: 14/Nov/18 21:55
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#7029: [BEAM-5320] Finish Python 3 porting for testing module
URL: https://github.com/apache/beam/pull/7029#discussion_r233635345
##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -223,7 +223,7 @@ def __init__(self,
if target_batch_duration_secs and target_batch_duration_secs <= 0:
raise ValueError("target_batch_duration_secs (%s) must be positive" % (
target_batch_duration_secs))
- if max(0, target_batch_overhead, target_batch_duration_secs) == 0:
+ if not (target_batch_overhead or target_batch_duration_secs):
Review comment:
These are changes introduced in #7022. This PR is rebased on top of that
one, since those changes have an impact on the testing module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166137)
Time Spent: 1h 40m (was: 1.5h)
> Finish Python 3 porting for testing module
> ------------------------------------------
>
> Key: BEAM-5320
> URL: https://issues.apache.org/jira/browse/BEAM-5320
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
