[
https://issues.apache.org/jira/browse/BEAM-5320?focusedWorklogId=166136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166136
]
ASF GitHub Bot logged work on BEAM-5320:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 21:53
Start Date: 14/Nov/18 21:53
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #7029:
[BEAM-5320] Finish Python 3 porting for testing module
URL: https://github.com/apache/beam/pull/7029#discussion_r233631436
##########
File path: sdks/python/apache_beam/testing/util.py
##########
@@ -113,14 +113,19 @@ def matcher(elements):
# However the sorting does not go beyond top level therefore [1,2] and [2,1]
# are considered equal and [[1,2]] and [[2,1]] are not.
def equal_to(expected):
- expected = list(expected)
def _equal(actual):
- sorted_expected = sorted(expected)
- sorted_actual = sorted(actual)
- if sorted_expected != sorted_actual:
+ expected_list = list(expected)
+ for element in actual:
+ try:
+ expected_list.remove(element)
Review comment:
This no longer does what the above comment about sorting. Please update the
comment. (or do it in a follow up)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166136)
Time Spent: 1.5h (was: 1h 20m)
> Finish Python 3 porting for testing module
> ------------------------------------------
>
> Key: BEAM-5320
> URL: https://issues.apache.org/jira/browse/BEAM-5320
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
