[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=166579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166579
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/18 18:37
Start Date: 15/Nov/18 18:37
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6969:
[BEAM-2939] SplittableDoFn Java SDK API Changes
URL: https://github.com/apache/beam/pull/6969#discussion_r233954925
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java
##########
@@ -1182,18 +1183,24 @@ private static boolean
hasTimestampAnnotation(List<Annotation> annotations) {
errors.checkArgument(void.class.equals(m.getReturnType()), "Must return
void");
Type[] params = m.getGenericParameterTypes();
- errors.checkArgument(params.length == 3, "Must have exactly 3 arguments");
+ errors.checkArgument(params.length == 4, "Must have 4 arguments");
Review comment:
If we expect a specific set of parameters and order, can we upgrade this
error message to explicitly state it? I'm imagining writing this method
signature and hitting each of these errors one at a time to deduce the correct
signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166579)
Time Spent: 6h 10m (was: 6h)
> Fn API streaming SDF support
> ----------------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
