[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=166574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166574
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/18 18:37
Start Date: 15/Nov/18 18:37
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6969:
[BEAM-2939] SplittableDoFn Java SDK API Changes
URL: https://github.com/apache/beam/pull/6969#discussion_r233944872
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -838,4 +872,40 @@ public final void prepareForProcessing() {}
*/
@Override
public void populateDisplayData(DisplayData.Builder builder) {}
+
+ /**
+ * A parameter that is accessible during {@link StartBundle @StartBundle},
{@link
Review comment:
Can you provide any context as to how you chose this API for registering
callbacks?
Some thoughts / questions (please answer in javadoc where appropriate):
1. How did you choose the three methods (`@StartBundle`, `@ProcessElement`,
and `@FinishBundle`) to expose this callback interface? Is there good reason
not to allow registering the callback in other places?
1. Is it valid to register multiple callbacks? Will they all be invoked, or
only the most recently registered?
1. In most other cases, users register DoFn callback via annotated methods.
Would it be more consistent to provide a `@FinalizeBundle` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166574)
Time Spent: 6h (was: 5h 50m)
> Fn API streaming SDF support
> ----------------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 6h
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
