[ 
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=166578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166578
 ]

ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/18 18:37
            Start Date: 15/Nov/18 18:37
    Worklog Time Spent: 10m 
      Work Description: swegner commented on a change in pull request #6969: 
[BEAM-2939] SplittableDoFn Java SDK API Changes
URL: https://github.com/apache/beam/pull/6969#discussion_r233934983
 
 

 ##########
 File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
 ##########
 @@ -780,7 +802,7 @@ public Duration getAllowedTimestampSkew() {
   // This can't be put into ProcessContinuation itself due to the following 
problem:
   // 
http://ternarysearch.blogspot.com/2013/07/static-initialization-deadlock.html
   private static final ProcessContinuation PROCESS_CONTINUATION_STOP =
-      new AutoValue_DoFn_ProcessContinuation(false, Duration.ZERO);
+      new AutoValue_DoFn_ProcessContinuation(false, new Instant());
 
 Review comment:
   nit: `Instant.now()` is equivalent but more self-describing. Recommend 
converting here and below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 166578)
    Time Spent: 6h 10m  (was: 6h)

> Fn API streaming SDF support
> ----------------------------
>
>                 Key: BEAM-2939
>                 URL: https://issues.apache.org/jira/browse/BEAM-2939
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model
>            Reporter: Henning Rohde
>            Assignee: Luke Cwik
>            Priority: Major
>              Labels: portability
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to