[
https://issues.apache.org/jira/browse/BEAM-5321?focusedWorklogId=168783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-168783
]
ASF GitHub Bot logged work on BEAM-5321:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/18 12:32
Start Date: 22/Nov/18 12:32
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#7104: [BEAM-5321] Port transforms package to Python 3
URL: https://github.com/apache/beam/pull/7104#discussion_r235493551
##########
File path: sdks/python/apache_beam/transforms/ptransform_test.py
##########
@@ -1695,11 +1702,18 @@ def test_mean_per_key_pipeline_checking_violated(self):
| 'EvenMean' >> combine.Mean.PerKey())
self.p.run()
- self.assertEqual(
- "Type hint violation for 'CombinePerKey(MeanCombineFn)': "
- "requires Tuple[TypeVariable[K], Union[float, int, long]] "
- "but got Tuple[str, str] for element",
- e.exception.args[0])
+ if sys.version_info[0] >= 3:
+ expected_msg = \
+ "Type hint violation for 'CombinePerKey(MeanCombineFn)': " \
+ "requires Tuple[TypeVariable[K], Union[float, int]] " \
Review comment:
In Python 3, short integers are gone and `long` has become `int`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 168783)
Time Spent: 1h 20m (was: 1h 10m)
> Finish Python 3 porting for transforms module
> ---------------------------------------------
>
> Key: BEAM-5321
> URL: https://issues.apache.org/jira/browse/BEAM-5321
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
