[
https://issues.apache.org/jira/browse/BEAM-5321?focusedWorklogId=172028&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172028
]
ASF GitHub Bot logged work on BEAM-5321:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/18 19:41
Start Date: 04/Dec/18 19:41
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #7104:
[BEAM-5321] Port transforms package to Python 3
URL: https://github.com/apache/beam/pull/7104#discussion_r238809795
##########
File path: sdks/python/setup.py
##########
@@ -102,16 +102,17 @@ def get_version():
cythonize = lambda *args, **kwargs: []
REQUIRED_PACKAGES_PY2_ONLY = [
- 'avro>=1.8.1,<2.0.0'
+ 'avro>=1.8.1,<2.0.0',
+ 'dill>=0.2.6,<=0.2.8.2',
]
REQUIRED_PACKAGES_PY3_ONLY = [
- 'avro-python3>=1.8.1,<2.0.0'
+ 'avro-python3>=1.8.1,<2.0.0',
Review comment:
We can simplify requirements spec with `python_version` qualifier: See
example at:
https://github.com/apache/beam/blob/95d0ac5e5cb59fd0c6a8a4861a38a7087a6c46b5/sdks/python/container/base_image_requirements.txt#L27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172028)
Time Spent: 1h 50m (was: 1h 40m)
> Finish Python 3 porting for transforms module
> ---------------------------------------------
>
> Key: BEAM-5321
> URL: https://issues.apache.org/jira/browse/BEAM-5321
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
