[
https://issues.apache.org/jira/browse/BEAM-3659?focusedWorklogId=169223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169223
]
ASF GitHub Bot logged work on BEAM-3659:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/18 19:52
Start Date: 25/Nov/18 19:52
Worklog Time Spent: 10m
Work Description: cademarkegard commented on a change in pull request
#7126: [BEAM-3659] Port UserScoreTest off DoFnTester
URL: https://github.com/apache/beam/pull/7126#discussion_r236087366
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/game/UserScoreTest.java
##########
@@ -92,13 +104,12 @@
/** Test the {@link ParseEventFn} {@link
org.apache.beam.sdk.transforms.DoFn}. */
@Test
public void testParseEventFn() throws Exception {
- DoFnTester<String, GameActionInfo> parseEventFn = DoFnTester.of(new
ParseEventFn());
+ PCollection<String> input =
p.apply(Create.of(GAME_EVENTS).withCoder(StringUtf8Coder.of()));
Review comment:
I originally had it because the other tests were also using it. I've removed
the coder from the other examples to stay consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169223)
Time Spent: 1h 10m (was: 1h)
> Port UserScoreTest off DoFnTester
> ---------------------------------
>
> Key: BEAM-3659
> URL: https://issues.apache.org/jira/browse/BEAM-3659
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Cade Markegard
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
