[
https://issues.apache.org/jira/browse/BEAM-3659?focusedWorklogId=169535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169535
]
ASF GitHub Bot logged work on BEAM-3659:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 22:45
Start Date: 26/Nov/18 22:45
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#7126: [BEAM-3659] Port UserScoreTest off DoFnTester
URL: https://github.com/apache/beam/pull/7126#discussion_r236457481
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/game/UserScore.java
##########
@@ -108,8 +112,39 @@ public String getKey(String keyname) {
}
}
- public Long getTimestamp() {
- return this.timestamp;
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
Review comment:
Findbugs and I have a mild feud over this one, as I care more about the
usual properties of equality than the usual properties of inheritance. One is
much older and more clearly timeless than the other... :-)
Your change is g2g though. This is a corner case with no right answer, so
making findbugs happy by calling a getter is just fine with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 169535)
Time Spent: 1h 40m (was: 1.5h)
> Port UserScoreTest off DoFnTester
> ---------------------------------
>
> Key: BEAM-3659
> URL: https://issues.apache.org/jira/browse/BEAM-3659
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Cade Markegard
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
