[
https://issues.apache.org/jira/browse/BEAM-3659?focusedWorklogId=170322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170322
]
ASF GitHub Bot logged work on BEAM-3659:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Nov/18 17:16
Start Date: 28/Nov/18 17:16
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#7126: [BEAM-3659] Port UserScoreTest off DoFnTester
URL: https://github.com/apache/beam/pull/7126#discussion_r237180646
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/game/UserScoreTest.java
##########
@@ -92,13 +104,12 @@
/** Test the {@link ParseEventFn} {@link
org.apache.beam.sdk.transforms.DoFn}. */
@Test
Review comment:
Yes, agree with @kennknowles , sorry for misleading with that. I followed
the same strategy as we have for other tests (in this test suite and in other
similars) that are marked with this annotation. Don't we have to clean them up?
In the same time, `ValidatesRunner extends NeedsRunner` and Javadoc of
`NeedsRunner` says:
```
/**
* Category tag for validation tests which utilize {@link TestPipeline} for
execution and expect to
* be executed by a {@link PipelineRunner}.
*/
```
So, don't we have to mark all "TestPipeline"-ed tests with `NeedsRunner`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170322)
Time Spent: 2.5h (was: 2h 20m)
> Port UserScoreTest off DoFnTester
> ---------------------------------
>
> Key: BEAM-3659
> URL: https://issues.apache.org/jira/browse/BEAM-3659
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Cade Markegard
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
