[
https://issues.apache.org/jira/browse/BEAM-3659?focusedWorklogId=170744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170744
]
ASF GitHub Bot logged work on BEAM-3659:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 18:13
Start Date: 29/Nov/18 18:13
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#7126: [BEAM-3659] Port UserScoreTest off DoFnTester
URL: https://github.com/apache/beam/pull/7126#discussion_r237600517
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/game/UserScoreTest.java
##########
@@ -92,13 +104,12 @@
/** Test the {@link ParseEventFn} {@link
org.apache.beam.sdk.transforms.DoFn}. */
@Test
Review comment:
That's right. You do need to put the DirectRunner on the classpath and
TestPipeline will pick it up.
The `@Category(NeedsRunner.class)` annotation is pretty much just so we can
scrape them out of the SDK jar, since it cannot depend on the DirectRunner. In
maven it would be a (spurious) cyclic dependency problem. With gradle I think
not a problem, actually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170744)
Time Spent: 3h (was: 2h 50m)
> Port UserScoreTest off DoFnTester
> ---------------------------------
>
> Key: BEAM-3659
> URL: https://issues.apache.org/jira/browse/BEAM-3659
> Project: Beam
> Issue Type: Sub-task
> Components: examples-java
> Reporter: Kenneth Knowles
> Assignee: Cade Markegard
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
