[
https://issues.apache.org/jira/browse/BEAM-6094?focusedWorklogId=170901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170901
]
ASF GitHub Bot logged work on BEAM-6094:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/18 00:07
Start Date: 30/Nov/18 00:07
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #7078:
[BEAM-6094] Implement external environment for portable BeamPython.
URL: https://github.com/apache/beam/pull/7078#discussion_r237704538
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -118,10 +151,12 @@ def run_pipeline(self, pipeline):
docker = DockerizedJobServer()
job_endpoint = docker.start()
- proto_context = pipeline_context.PipelineContext(
+ # This is needed as we start a worker server if one is requested
+ # but none is provided.
+ cleanup_callbacks = []
Review comment:
Instead of passing a list to get the callback from
PortableRunner._create_environment, shall we make
PortableRunner._create_environment return (environement, cleanup_callback)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170901)
Time Spent: 40m (was: 0.5h)
> Implement External environment for Portable Beam
> ------------------------------------------------
>
> Key: BEAM-6094
> URL: https://issues.apache.org/jira/browse/BEAM-6094
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
