[
https://issues.apache.org/jira/browse/BEAM-6094?focusedWorklogId=172248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172248
]
ASF GitHub Bot logged work on BEAM-6094:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 11:48
Start Date: 05/Dec/18 11:48
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7078:
[BEAM-6094] Implement external environment for portable BeamPython.
URL: https://github.com/apache/beam/pull/7078#discussion_r239032505
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -606,13 +606,15 @@ def visit_value(self, value, _):
return Visitor.ok
def to_runner_api(
- self, return_context=False, context=None, use_fake_coders=False):
+ self, return_context=False, context=None, use_fake_coders=False,
+ default_environment=None):
"""For internal use only; no backwards-compatibility guarantees."""
from apache_beam.runners import pipeline_context
from apache_beam.portability.api import beam_runner_api_pb2
if context is None:
context = pipeline_context.PipelineContext(
- use_fake_coders=use_fake_coders)
+ use_fake_coders=use_fake_coders,
+ default_environment=default_environment)
Review comment:
It's up to the context to come up with a default environment if none is set.
The argument here just overrides that default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172248)
Time Spent: 1h 40m (was: 1.5h)
> Implement External environment for Portable Beam
> ------------------------------------------------
>
> Key: BEAM-6094
> URL: https://issues.apache.org/jira/browse/BEAM-6094
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
