[
https://issues.apache.org/jira/browse/BEAM-6094?focusedWorklogId=172249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172249
]
ASF GitHub Bot logged work on BEAM-6094:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 11:48
Start Date: 05/Dec/18 11:48
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7078:
[BEAM-6094] Implement external environment for portable BeamPython.
URL: https://github.com/apache/beam/pull/7078#discussion_r239033306
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -118,10 +151,12 @@ def run_pipeline(self, pipeline):
docker = DockerizedJobServer()
job_endpoint = docker.start()
- proto_context = pipeline_context.PipelineContext(
+ # This is needed as we start a worker server if one is requested
+ # but none is provided.
+ cleanup_callbacks = []
Review comment:
I cleaned this up providing a new LOOPBACK environment rather than have
external implicitly create workers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172249)
> Implement External environment for Portable Beam
> ------------------------------------------------
>
> Key: BEAM-6094
> URL: https://issues.apache.org/jira/browse/BEAM-6094
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
