[
https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=171740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171740
]
ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/18 22:40
Start Date: 03/Dec/18 22:40
Worklog Time Spent: 10m
Work Description: ryan-williams commented on a change in pull request
#7183: [BEAM-6165] send metrics to Flink in portable Flink runner
URL: https://github.com/apache/beam/pull/7183#discussion_r238466784
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java
##########
@@ -77,12 +82,72 @@ public FlinkMetricContainer(RuntimeContext runtimeContext)
{
this.metricsAccumulator = (MetricsAccumulator) metricsAccumulator;
}
- MetricsContainer getMetricsContainer(String stepName) {
+ public MetricsContainer getMetricsContainer(String stepName) {
return metricsAccumulator != null
? metricsAccumulator.getLocalValue().getContainer(stepName)
: null;
}
+ /**
+ * Parse a {@link MetricName} from a {@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.MonitoringInfoUrns.Enum}
+ *
+ * <p>Should be consistent with {@code parse_namespace_and_name} in
monitoring_infos.py
Review comment:
Wanted to flag this for @ajamato in particular as the author of [the python
code I mimicked
here](https://github.com/apache/beam/blob/6b7cf422733a82aabb8e257e975d9e9c5e785376/sdks/python/apache_beam/metrics/monitoring_infos.py#L228-L236).
How important is it that the python and java SDKs parse metric URNs into a
{namespace, name} pairs in the same way?
From what I can tell, It may not be critical, though we should still
probably agree on one semantic interpretation of what is "namespace" vs "name"
of e.g.
[`"beam:metric:element_count:v1"`](https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto#L360-L361).
With `monitoring_infos.py` as the reference implementation, the answer is
{`"beam"`, `"metric:element_count:v1"`}; shall I encode that in a comment in
`beam_fn_api.proto`, and reference it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171740)
Time Spent: 3h 10m (was: 3h)
> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
> Key: BEAM-6165
> URL: https://issues.apache.org/jira/browse/BEAM-6165
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Major
> Labels: metrics, portability, portability-flink
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runner in the Python SDK (and likely
> Java soon), but the portable Flink runner doesn't pass them on to Flink,
> which it should, so that users can see them in e.g. the Flink UI or via any
> Flink metrics reporters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
