[
https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=171839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171839
]
ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/18 05:18
Start Date: 04/Dec/18 05:18
Worklog Time Spent: 10m
Work Description: ryan-williams commented on a change in pull request
#7183: [BEAM-6165] send metrics to Flink in portable Flink runner
URL: https://github.com/apache/beam/pull/7183#discussion_r238532219
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -132,7 +134,9 @@ static StreamExecutionEnvironment
createStreamExecutionEnvironment(
// depending on the master, create the right environment.
if ("[local]".equals(masterUrl)) {
- flinkStreamEnv = StreamExecutionEnvironment.createLocalEnvironment();
+ flinkStreamEnv =
+ StreamExecutionEnvironment.createLocalEnvironment(
+ getDefaultLocalParallelism(), flinkConfig);
Review comment:
@mxm previously, a Flink `Configuration` in scope was thrown away in favor
of a `new Configuration()`, dropping settings from `--flink-conf-dir` that were
[supposed to override
`$FLINK_CONF_DIR`](https://github.com/apache/beam/pull/7031#issuecomment-442112065),
and generally going against the patterns I know for building up a config
object like this from sources with different precedence.
So this seemed like a bug-fix worth doing in general, which also blocked my
metrics configs from propagating as needed here.
@tweise `$FLINK_CONF_DIR` vs `--flink-conf-dir` is an interesting question…
is one clearly preferred? I thought the latter was more explicit, easier to
pass to the job-server, and overrides the former, but I didn't fully follow the
rationale around it in #7031.
Also if I factored the metrics YAML file out as a test resource [like you
suggested below](https://github.com/apache/beam/pull/7183/files#r238293952), I
don't see it being any easier to point at via `$FLINK_CONF_DIR` vs
`--flink-conf-dir`, but I may be missing things!
lmk what you think, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171839)
Time Spent: 3h 20m (was: 3h 10m)
> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
> Key: BEAM-6165
> URL: https://issues.apache.org/jira/browse/BEAM-6165
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Major
> Labels: metrics, portability, portability-flink
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runner in the Python SDK (and likely
> Java soon), but the portable Flink runner doesn't pass them on to Flink,
> which it should, so that users can see them in e.g. the Flink UI or via any
> Flink metrics reporters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
