[
https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=171996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171996
]
ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/18 18:28
Start Date: 04/Dec/18 18:28
Worklog Time Spent: 10m
Work Description: ryan-williams commented on a change in pull request
#7183: [BEAM-6165] send metrics to Flink in portable Flink runner
URL: https://github.com/apache/beam/pull/7183#discussion_r238783431
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -65,19 +69,58 @@ class
FlinkRunnerTest(portable_runner_test.PortableRunnerTest):
_use_grpc = True
_use_subprocesses = True
+ conf_dir = None
+
+ @classmethod
+ def tearDownClass(cls):
+ if cls.conf_dir and exists(cls.conf_dir):
+ logging.info("removing conf dir: %s" % cls.conf_dir)
+ rmtree(cls.conf_dir)
+ super(FlinkRunnerTest, cls).tearDownClass()
+
+ @classmethod
+ def _create_conf_dir(cls):
+ """Create (and save a static reference to) a "conf dir", used to provide
Review comment:
looking at this more, I think it's less desirable to put the config settings
into a `flink-conf.yaml` that gets checked in, because the temporary output
file needs to be specified as the value of the `metrics.reporter.file.path`
config key, and I think it's better for that to be an on-the-fly temporary path
than to e.g. write it out in the built source tree.
lmk what you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171996)
Time Spent: 4.5h (was: 4h 20m)
> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
> Key: BEAM-6165
> URL: https://issues.apache.org/jira/browse/BEAM-6165
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Major
> Labels: metrics, portability, portability-flink
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runner in the Python SDK (and likely
> Java soon), but the portable Flink runner doesn't pass them on to Flink,
> which it should, so that users can see them in e.g. the Flink UI or via any
> Flink metrics reporters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
