[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172690
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 16:51
Start Date: 06/Dec/18 16:51
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r239524179
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -307,10 +344,17 @@ void updateProgress() {
grpcWriteOperation.abortWait();
}
- BeamFnApi.Metrics metrics =
MoreFutures.get(bundleProcessOperation.getMetrics());
+ //TODO: Replace getProcessBundleProgress with getMonitoringInfos when
Metrics is deprecated.
Review comment:
+1 to tag a JIRA. It's useful to have some additional context for when the
TODO inevitably gets stale and needs clarification to be actionable.
The JIRA doesn't have to be explicitly for doing this cleanup. It should
track when this TODO is ready to implement or obsolete. In this case, it would
make sense to have a JIRA for deprecating the legacy Metrics.
Google's public style guides [offer similar
advice](https://google.github.io/styleguide/cppguide.html#TODO_Comments) (we
don't follow Google styleguides in Beam, although the advice is useful):
> Use TODO comments for code that is temporary, a short-term solution, or
good-enough but not perfect.
>
> TODOs should include the string TODO in all caps, followed by the name,
e-mail address, bug ID, or other identifier of the person or issue with the
best context about the problem referenced by the TODO. The main purpose is to
have a consistent TODO that can be searched to find out how to get more details
upon request. A TODO is not a commitment that the person referenced will fix
the problem. Thus when you create a TODO with a name, it is almost always your
name that is given.
>
> `// TODO([email protected]): Use a "*" here for concatenation operator.`
> `// TODO(Zeke) change this to use relations.`
> `// TODO(bug 12345): remove the "Last visitors" feature`
>
> If your TODO is of the form "At a future date do something" make sure that
you either include a very specific date ("Fix by November 2005") or a very
specific event ("Remove this code when all clients can handle XML responses.").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172690)
Time Spent: 4.5h (was: 4h 20m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
