[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172807
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 19:49
Start Date: 06/Dec/18 19:49
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r239590504
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -351,7 +398,115 @@ void updateProgress() {
}
}
- private void updateMetrics(BeamFnApi.Metrics metrics) {
+ // Keeping this as static class for this iteration. Will extract to
separate file and generalize
+ // when more counter types are added.
+ // todomigryz: define counter transformer factory
+ // that can provide respective counter transformer for different type of
counters.
+ // (ie RowCountCounterTranformer, MSecCounterTransformer,
UserCounterTransformer, etc)
+ private static class MonitoringInfoToCounterUpdateTransformer {
+
+ private final Map<String, DataflowStepContext> transformIdMapping;
+
+ public MonitoringInfoToCounterUpdateTransformer(
+ final Map<String, DataflowStepContext> transformIdMapping) {
+ this.transformIdMapping = transformIdMapping;
+ }
+
+ // todo: search code for "beam:metrics"... and replace them with
relevant enums from
+ // proto after rebasing above https://github.com/apache/beam/pull/6799
that
+ // introduces relevant proto entries.
+ final String BEAM_METRICS_USER_PREFIX = "beam:metric:user";
+
+ private CounterUpdate monitoringInfoToCounterUpdate(MonitoringInfo
monitoringInfo) {
+ long value =
monitoringInfo.getMetric().getCounterData().getInt64Value();
+ String urn = monitoringInfo.getUrn();
+
+ String type = monitoringInfo.getType();
+
+ // todomigryz: run MonitoringInfo through validation process.
+ // refer to https://github.com/apache/beam/pull/6799
+
+ if (urn.startsWith(BEAM_METRICS_USER_PREFIX)) {
+ if (!type.equals("beam:metrics:sum_int_64")) {
+ LOG.warn(
Review comment:
It would be good to understand the scenarios we could reach these states and
design error handling appropriately.
If the only scenario that would produce this is a bug in the SDK, then we
should expose that bug as early as possible to get it fixed. Log-and-continue
means that we'll ignore it, and unless we have an explicit test our users will
notice before we do.
I doubt we have a consistent methodology for error handling in Beam, but I
remember this came up when designing DIsplayData in the java SDK. We decided
errors in constructing DisplayData from user-defined PTransforms should throw
and block job submission, rather than continuing with empty Display Data. This
feels similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172807)
Time Spent: 5.5h (was: 5h 20m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
