[
https://issues.apache.org/jira/browse/BEAM-6120?focusedWorklogId=172822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172822
]
ASF GitHub Bot logged work on BEAM-6120:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 20:29
Start Date: 06/Dec/18 20:29
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7127:
[BEAM-6120] Support retrieval of large gbk iterables over the state API.
URL: https://github.com/apache/beam/pull/7127#discussion_r239593123
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -637,20 +637,33 @@ class SequenceCoderImpl(StreamCoderImpl):
countX element(0) element(1) ... element(countX - 1)
0
+ If writing to state is enabled, the final terminating 0 will instead be
+ repaced with::
+
+ -1
+ len(state_token)
Review comment:
important to state that len(state_token) is encoded as varint64
nit: not that important but you could drop the `-1` and encode it as
`-len(state_token)`. Will save a few bytes within the encoding since -1 will be
9 bytes already as a varint64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172822)
Time Spent: 2h 50m (was: 2h 40m)
> Support retrieval of large gbk iterables over the state API.
> ------------------------------------------------------------
>
> Key: BEAM-6120
> URL: https://issues.apache.org/jira/browse/BEAM-6120
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
