[
https://issues.apache.org/jira/browse/BEAM-6120?focusedWorklogId=172873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172873
]
ASF GitHub Bot logged work on BEAM-6120:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 22:48
Start Date: 06/Dec/18 22:48
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #7127:
[BEAM-6120] Support retrieval of large gbk iterables over the state API.
URL: https://github.com/apache/beam/pull/7127#discussion_r239643988
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -637,20 +637,33 @@ class SequenceCoderImpl(StreamCoderImpl):
countX element(0) element(1) ... element(countX - 1)
0
+ If writing to state is enabled, the final terminating 0 will instead be
+ repaced with::
+
+ -1
+ len(state_token)
Review comment:
I would rather keep other negative values for possible future expansion. 9
bytes is inconsequential once this code is hit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172873)
Time Spent: 3h 10m (was: 3h)
> Support retrieval of large gbk iterables over the state API.
> ------------------------------------------------------------
>
> Key: BEAM-6120
> URL: https://issues.apache.org/jira/browse/BEAM-6120
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
