[
https://issues.apache.org/jira/browse/BEAM-6245?focusedWorklogId=176513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176513
]
ASF GitHub Bot logged work on BEAM-6245:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Dec/18 13:05
Start Date: 18/Dec/18 13:05
Worklog Time Spent: 10m
Work Description: dawidwys commented on issue #7296: [BEAM-6245] Add
integration test for FlinkTransformOverrides
URL: https://github.com/apache/beam/pull/7296#issuecomment-448214338
Hi @mxm, generally I think it is a reasonable improvement. One think I don't
like is that the `shouldUseTransformOverrides` uses very internal APIs + mocks
and in my opinion is fragile for any change.
How about check if the pipeline has everything replaced correctly? I mean if
the overrides were actually applied to the pipeline. But I might be just
nitpicking. Other than the test it looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 176513)
Time Spent: 40m (was: 0.5h)
> Add test for FlinkTransformOverrides
> ------------------------------------
>
> Key: BEAM-6245
> URL: https://issues.apache.org/jira/browse/BEAM-6245
> Project: Beam
> Issue Type: Test
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.10.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We don't test that FlinkTransformOverrides are applied during pipeline
> translation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
