[
https://issues.apache.org/jira/browse/BEAM-6245?focusedWorklogId=176986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176986
]
ASF GitHub Bot logged work on BEAM-6245:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 13:38
Start Date: 19/Dec/18 13:38
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7296: [BEAM-6245] Add
integration test for FlinkTransformOverrides
URL: https://github.com/apache/beam/pull/7296#issuecomment-448599422
This is a safe guard in case during a refactoring we removed the replaceAll
method. I think it does provide value as a lightweight integration test.
Testing only the transform replacement itself does not guarantee they are
applied during translation.
Just to clarify, the test coverage in your PR is excellent. The wording
"followup" is a bit misleading. Sorry about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 176986)
Time Spent: 1h 20m (was: 1h 10m)
> Add test for FlinkTransformOverrides
> ------------------------------------
>
> Key: BEAM-6245
> URL: https://issues.apache.org/jira/browse/BEAM-6245
> Project: Beam
> Issue Type: Test
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.10.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We don't test that FlinkTransformOverrides are applied during pipeline
> translation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
