[ 
https://issues.apache.org/jira/browse/BEAM-6245?focusedWorklogId=176963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176963
 ]

ASF GitHub Bot logged work on BEAM-6245:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Dec/18 13:12
            Start Date: 19/Dec/18 13:12
    Worklog Time Spent: 10m 
      Work Description: dawidwys commented on issue #7296: [BEAM-6245] Add 
integration test for FlinkTransformOverrides
URL: https://github.com/apache/beam/pull/7296#issuecomment-448592255
 
 
   I see, but then I see very little value of this test. In the end we are not 
testing if other methods inside of the implementation of `Piepline#translate` 
are called, right? As I said this test is ok I guess, but with or without the 
test I would feel equally comfortable in regards to test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 176963)
    Time Spent: 1h 10m  (was: 1h)

> Add test for FlinkTransformOverrides
> ------------------------------------
>
>                 Key: BEAM-6245
>                 URL: https://issues.apache.org/jira/browse/BEAM-6245
>             Project: Beam
>          Issue Type: Test
>          Components: runner-flink
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 2.10.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We don't test that FlinkTransformOverrides are applied during pipeline 
> translation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to