[
https://issues.apache.org/jira/browse/BEAM-3580?focusedWorklogId=181970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181970
]
ASF GitHub Bot logged work on BEAM-3580:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/19 19:10
Start Date: 07/Jan/19 19:10
Worklog Time Spent: 10m
Work Description: htyleo commented on pull request #7422: [BEAM-3580] Use
a separate coder for string
URL: https://github.com/apache/beam/pull/7422#discussion_r245765155
##########
File path: sdks/go/pkg/beam/core/graph/coder/coder.go
##########
@@ -122,6 +122,7 @@ type Kind string
const (
Custom Kind = "Custom" // Implicitly length-prefixed
Bytes Kind = "bytes" // Implicitly length-prefixed as part of
the encoding
+ String Kind = "string" // Implicitly length-prefixed as part of
the encoding
Review comment:
Oh, thanks for pointing that out! I misunderstood the meaning of "custom
coder" in the bug description.
I'm going to close this PR and file another one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 181970)
Time Spent: 50m (was: 40m)
> Do not use Go BytesCoder to encode string
> -----------------------------------------
>
> Key: BEAM-3580
> URL: https://issues.apache.org/jira/browse/BEAM-3580
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Henning Rohde
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We should not use the same built-in coder for two different types. It creates
> the need for conversions at inopportune times in the runtime.
>
> One option would be to a custom coder that shares encoding with bytes, given
> that bytes are length prefixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
