[
https://issues.apache.org/jira/browse/BEAM-3580?focusedWorklogId=181982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181982
]
ASF GitHub Bot logged work on BEAM-3580:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/19 19:30
Start Date: 07/Jan/19 19:30
Worklog Time Spent: 10m
Work Description: htyleo commented on issue #7422: [BEAM-3580] Use a
separate coder for string
URL: https://github.com/apache/beam/pull/7422#issuecomment-452053094
> These coders represent "standard" beam coders as defined by the FnAPI, so
we can't simply add to them. An alternative would be to have the String Coder
be a custom coder instead, that we "install" by default, similar to how we're
currently handling Protocol Buffers or JSON.
>
> This will need to be tested against the Universal Local Runner, to verify
the semantics.
Thanks @lostluck for correcting me. I'm going to close this PR and file
another one, which should implement a custom coder (instead of a built-in
coder) for string. I will try testing it against the Universal Local Runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 181982)
Time Spent: 1h 10m (was: 1h)
> Do not use Go BytesCoder to encode string
> -----------------------------------------
>
> Key: BEAM-3580
> URL: https://issues.apache.org/jira/browse/BEAM-3580
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Henning Rohde
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We should not use the same built-in coder for two different types. It creates
> the need for conversions at inopportune times in the runtime.
>
> One option would be to a custom coder that shares encoding with bytes, given
> that bytes are length prefixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
