[
https://issues.apache.org/jira/browse/BEAM-3580?focusedWorklogId=186083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186083
]
ASF GitHub Bot logged work on BEAM-3580:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 00:33
Start Date: 17/Jan/19 00:33
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #7543: [BEAM-3580]
Use a custom coder for strings.
URL: https://github.com/apache/beam/pull/7543
Use a custom coder for strings in the Go SDK. CustomCoders are already
length prefixed, so this does the simple conversion.
This PR also removes all places I could recall do a manual []byte to string
conversion which was a consequence of the previous approach. This should yield
a mild performance improvement in that the conversions are done earlier rather
than right before invocation. Similarly, []bytes are no longer getting checked
that they are strings.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186083)
Time Spent: 1h 20m (was: 1h 10m)
> Do not use Go BytesCoder to encode string
> -----------------------------------------
>
> Key: BEAM-3580
> URL: https://issues.apache.org/jira/browse/BEAM-3580
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We should not use the same built-in coder for two different types. It creates
> the need for conversions at inopportune times in the runtime.
>
> One option would be to a custom coder that shares encoding with bytes, given
> that bytes are length prefixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
