[
https://issues.apache.org/jira/browse/BEAM-10341?focusedWorklogId=453761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453761
]
ASF GitHub Bot logged work on BEAM-10341:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/20 03:25
Start Date: 02/Jul/20 03:25
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448727139
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -1053,6 +1056,51 @@ public Duration getAllowedTimestampSkew() {
@Experimental(Kind.SPLITTABLE_DO_FN)
public @interface SplitRestriction {}
+ /**
+ * Annotation for the method that truncates the restriction of a <a
+ * href="https://s.apache.org/splittable-do-fn";>splittable</a> {@link DoFn}
into a bounded one to
+ * be processed when pipeline starts to drain.
+ *
+ * <p>This method is used to perform truncation of the restriction while it
is not actively being
+ * processed.
+ *
+ * <p>Signature: {@code Optional<RestrictionT>
truncateRestriction(<arguments>);}
Review comment:
We should state what Optional.empty means as part of the contract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453761)
Time Spent: 4h 20m (was: 4h 10m)
> Support drain in SDF
> --------------------
>
> Key: BEAM-10341
> URL: https://issues.apache.org/jira/browse/BEAM-10341
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
